Let's try with a comma

.circleci/config.yml

@@ -19,7 +19,7 @@ executors:
     working_directory: ~/projects/Plume
     environment:
       RUST_TEST_THREADS: 1
-      FEATURES: <<#parameters.postgres>>postgres<</ parameters.postgres>><<^parameters.postgres>>sqlite<</parameters.postgres>>
+      FEATURES: <<#parameters.postgres>>postgres<</ parameters.postgres>><<^parameters.postgres>>sqlite<</parameters.postgres>>,ci
       DATABASE_URL: <<#parameters.postgres>>postgres://postgres@localhost/plume<</parameters.postgres>><<^parameters.postgres>>plume.sqlite<</parameters.postgres>>
 
 
@@ -226,7 +226,6 @@ jobs:
     steps:
     - restore_env:
         cache: none
-    - run: cargo build
     - run: crowdin upload -b master
 
 workflows:

.gitignore

@@ -18,4 +18,3 @@ tags.*
 search_index
 .buildconfig
 __pycache__
-/.vscode/

Cargo.toml

@@ -79,6 +79,7 @@ postgres = ["plume-models/postgres", "diesel/postgres"]
 sqlite = ["plume-models/sqlite", "diesel/sqlite"]
 debug-mailer = []
 test = []
+ci = ["plume-models/ci", "plume-api/ci", "plume-common/ci"]
 
 [workspace]
 members = ["plume-api", "plume-cli", "plume-models", "plume-common", "plume-front", "plume-macro"]

assets/themes/default/_global.scss

@@ -190,28 +190,7 @@ p.error {
 
  	background: $gray;
 
-  text-overflow: ellipsis;
+ 	text-overflow: ellipsis;
-
-  footer.authors {
-    div {
-      float: left;
-      margin-right: 0.25em;
-    }
-
-    .likes { color: $red; }
-    .reshares { color: $primary; }
-
-    span.likes, span.resahres {
-      font-family: "Route159",serif;
-      font-size: 1em;
-    }
-
-    svg.feather {
-      width: 0.85em;
-      height: 0.85em;
-    }
-  }
-
 
  	> * {
  	  margin: 20px;
@@ -490,6 +469,93 @@ figure {
 
 /// Small screens
 @media screen and (max-width: 600px) {
+  @keyframes menuOpening {
+    from {
+      transform: scaleX(0);
+      transform-origin: left;
+      opacity: 0;
+    }
+    to {
+      transform: scaleX(1);
+      transform-origin: left;
+      opacity: 1;
+    }
+  }
+
+  body > header {
+    flex-direction: column;
+
+    nav#menu {
+      display: inline-flex;
+      z-index: 21;
+    }
+
+    #content {
+      display: none;
+      appearance: none;
+      text-align: center;
+      z-index: 20;
+    }
+  }
+
+  body > header:focus-within #content, #content.show {
+    position: fixed;
+    display: flex;
+    flex-direction: column;
+    justify-content: flex-start;
+
+    top: 0;
+    left: 0;
+    width: 100%;
+    height: 100%;
+    box-sizing: border-box;
+
+    animation: 0.2s menuOpening;
+
+    &::before {
+      content: "";
+      position: absolute;
+      transform: skewX(-10deg);
+      top: 0;
+      left: -20%;
+      width: 100%;
+      height: 100%;
+
+      z-index: -10;
+
+      background: $primary;
+    }
+
+    > nav {
+      flex-direction: column;
+      align-items: flex-start;
+
+      a {
+        display: flex;
+        flex-direction: row;
+        align-items: center;
+        margin: 0;
+        padding: 1rem 1.5rem;
+        color: $background;
+        font-size: 1.4em;
+        font-weight: 300;
+
+        &.title { font-size: 1.8em; }
+
+        > *:first-child { width: 3rem; }
+        > img:first-child { height: 3rem; }
+        > *:last-child { margin-left: 1rem; }
+        > nav hr {
+          display: block;
+          margin: 0;
+          width: 100%;
+          border: solid $background 0.1rem;
+        }
+        .mobile-label { display: initial; }
+      }
+    }
+  }
+
   main .article-meta {
     > *, .comments {
       margin: 0 5%;

assets/themes/default/_header.scss

@@ -101,96 +101,6 @@ body > header {
   }
 }
 
-/// Small screens
-@media screen and (max-width: 600px) {
-  @keyframes menuOpening {
-    from {
-      transform: scaleX(0);
-      transform-origin: left;
-      opacity: 0;
-    }
-    to {
-      transform: scaleX(1);
-      transform-origin: left;
-      opacity: 1;
-    }
-  }
-
-  body > header {
-    flex-direction: column;
-
-    nav#menu {
-      display: inline-flex;
-      z-index: 21;
-    }
-
-    #content {
-      display: none;
-      appearance: none;
-      text-align: center;
-      z-index: 20;
-    }
-  }
-
-  body > header:focus-within #content, #content.show {
-    position: fixed;
-    display: flex;
-    flex-direction: column;
-    justify-content: flex-start;
-
-    top: 0;
-    left: 0;
-    width: 100%;
-    height: 100%;
-    box-sizing: border-box;
-
-    animation: 0.2s menuOpening;
-
-    &::before {
-      content: "";
-      position: absolute;
-      transform: skewX(-10deg);
-      top: 0;
-      left: -20%;
-      width: 100%;
-      height: 100%;
-
-      z-index: -10;
-
-      background: $primary;
-    }
-
-    > nav {
-      flex-direction: column;
-      align-items: flex-start;
-
-      a {
-        display: flex;
-        flex-direction: row;
-        align-items: center;
-        margin: 0;
-        padding: 1rem 1.5rem;
-        color: $background;
-        font-size: 1.4em;
-        font-weight: 300;
-
-        &.title { font-size: 1.8em; }
-
-        > *:first-child { width: 3rem; }
-        > img:first-child { height: 3rem; }
-        > *:last-child { margin-left: 1rem; }
-        > nav hr {
-          display: block;
-          margin: 0;
-          width: 100%;
-          border: solid $background 0.1rem;
-        }
-        .mobile-label { display: initial; }
-      }
-    }
-  }
-}
-
 /* Only enable label animations on large screens */
 @media screen and (min-width: 600px) {
  	header nav a {

plume-api/Cargo.toml

@@ -7,3 +7,6 @@ edition = "2018"
 [dependencies]
 serde = "1.0"
 serde_derive = "1.0"
+
+[features]
+ci = []

plume-api/src/lib.rs

@@ -1,3 +1,5 @@
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
+
 #[macro_use]
 extern crate serde_derive;
 

plume-cli/Cargo.toml

@@ -23,3 +23,4 @@ path = "../plume-models"
 [features]
 postgres = ["plume-models/postgres", "diesel/postgres"]
 sqlite = ["plume-models/sqlite", "diesel/sqlite"]
+ci = ["plume-models/ci"]

plume-cli/src/main.rs

@@ -1,7 +1,8 @@
-use dotenv;
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
 
 use clap::App;
 use diesel::Connection;
+use dotenv;
 use plume_models::{instance::Instance, Connection as Conn, CONFIG};
 use std::io::{self, prelude::*};
 

plume-common/Cargo.toml

@@ -30,3 +30,6 @@ version = "0.4"
 [dependencies.pulldown-cmark]
 default-features = false
 version = "0.2.0"
+
+[features]
+ci = []

plume-common/src/lib.rs

@@ -1,3 +1,4 @@
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
 #![feature(associated_type_defaults)]
 
 #[macro_use]

plume-front/Cargo.toml

@@ -13,3 +13,6 @@ gettext-utils = { git = "https://github.com/Plume-org/gettext-macros/", rev = "a
 lazy_static = "1.3"
 serde = "1.0"
 serde_json = "1.0"
+
+[features]
+ci = []

plume-front/src/main.rs

@@ -1,5 +1,6 @@
 #![recursion_limit = "128"]
 #![feature(decl_macro, proc_macro_hygiene, try_trait)]
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
 
 #[macro_use]
 extern crate gettext_macros;

plume-macro/Cargo.toml

@@ -19,3 +19,4 @@ syn = "0.15.27"
 default = []
 postgres = []
 sqlite = []
+ci = []

plume-macro/src/lib.rs

@@ -1,4 +1,5 @@
 #![recursion_limit = "128"]
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
 
 #[macro_use]
 extern crate quote;

plume-models/Cargo.toml

@@ -54,3 +54,4 @@ diesel_migrations = "1.3.0"
 [features]
 postgres = ["diesel/postgres", "plume-macro/postgres" ]
 sqlite = ["diesel/sqlite", "plume-macro/sqlite" ]
+ci = ["plume-macro/ci"]

plume-models/src/lib.rs

@@ -1,6 +1,7 @@
 #![feature(try_trait)]
 #![feature(never_type)]
 #![feature(proc_macro_hygiene)]
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
 
 #[macro_use]
 extern crate diesel;

plume-models/src/users.rs

@@ -54,7 +54,6 @@ pub enum Role {
 }
 
 #[derive(Queryable, Identifiable, Clone, Debug, AsChangeset)]
-#[changeset_options(treat_none_as_null = "true")]
 pub struct User {
     pub id: i32,
     pub username: String,

script/wasm-deps.sh

@@ -24,9 +24,9 @@ if [ $ARCH == "aarch64" -o $ARCH == "armv71" ] ; then
     apt-get install -y --no-install-recommends build-essential subversion ninja-build cmake
     mkdir -p /scratch/src
     cd /scratch/src
-    svn co http://llvm.org/svn/llvm-project/llvm/tags/RELEASE_900/final/ llvm
+    svn co http://llvm.org/svn/llvm-project/llvm/tags/RELEASE_800/final/ llvm
     cd /scratch/src/llvm/tools
-    svn co http://llvm.org/svn/llvm-project/lld/tags/RELEASE_900/final/ lld
+    svn co http://llvm.org/svn/llvm-project/lld/tags/RELEASE_800/final/ lld
     mkdir -p /scratch/build/arm
     cd /scratch/build/arm
     if [ "$ARCH" == "aarch64" ] ; then

snap/snapcraft.yaml

@@ -8,7 +8,7 @@ description: |
    * Media management: you can upload pictures to illustrate your articles, but also audio files if you host a podcast, and manage them all from Plume.
    * Federation: Plume is part of a network of interconnected websites called the Fediverse. Each of these websites (often called instances) have their own rules and thematics, but they can all communicate with each other.
    * Collaborative writing: invite other people to your blogs, and write articles together.
-grade: stable
+grade: devel # must be 'stable' to release into candidate/stable channels
 confinement: strict
 
 apps:
@@ -25,13 +25,12 @@ parts:
   plume:
     plugin: rust
     source: .
-    rust-revision: nightly-2020-01-15
+    rust-revision: nightly-2019-03-23
     build-packages:
       - libssl-dev
       - pkg-config
       - libsqlite3-dev
       - gettext
-      - libclang-8-dev
       - on arm64,armhf,ppc64el,s390x:
         - lld-8
     override-build: |
@@ -43,7 +42,7 @@ parts:
       # Only Tier 1 Rust platforms get rust-lld
       # On the others (arm64, armhf, powerpc64, s390x) fall back to using
       # the system LLD we've installed earlier.
-      case ${SNAPCRAFT_ARCH_TRIPLET} in \
+      case ${SNAPCRAFT_ARCH_TRIPLE} in \
         aarch64-linux-gnu|arm-linux-gnueabihf|powerpc64-linux-gnu|s390x-linux-gnu) \
           RUSTFLAGS="-C linker=lld-8" cargo web deploy -p plume-front --release \
           ;; \

src/main.rs

@@ -1,4 +1,5 @@
 #![allow(clippy::too_many_arguments)]
+#![cfg_attr(not(feature = "ci"), warn(missing_docs))]
 #![feature(decl_macro, proc_macro_hygiene, try_trait)]
 
 #[macro_use]

src/routes/session.rs

@@ -3,7 +3,7 @@ use lettre::Transport;
 use rocket::http::ext::IntoOwned;
 use rocket::{
     http::{uri::Uri, Cookie, Cookies, SameSite},
-    request::LenientForm,
+    request::{Form, LenientForm},
     response::{Flash, Redirect},
     State,
 };
@@ -159,7 +159,7 @@ pub struct ResetForm {
 #[post("/password-reset", data = "<form>")]
 pub fn password_reset_request(
     mail: State<'_, Arc<Mutex<Mailer>>>,
-    form: LenientForm<ResetForm>,
+    form: Form<ResetForm>,
     rockets: PlumeRocket,
 ) -> Ructe {
     if User::find_by_email(&*rockets.conn, &form.email).is_ok() {
@@ -216,7 +216,7 @@ fn passwords_match(form: &NewPasswordForm) -> Result<(), ValidationError> {
 #[post("/password-reset/<token>", data = "<form>")]
 pub fn password_reset(
     token: String,
-    form: LenientForm<NewPasswordForm>,
+    form: Form<NewPasswordForm>,
     rockets: PlumeRocket,
 ) -> Result<Flash<Redirect>, Ructe> {
     form.validate()

src/routes/user.rs

@@ -399,10 +399,7 @@ pub fn update(
         )
         .0,
     );
-    user.preferred_theme = form
+    user.preferred_theme = form.theme.clone();
-        .theme
-        .clone()
-        .and_then(|t| if &t == "" { None } else { Some(t) });
     user.hide_custom_css = form.hide_custom_css;
     let _: User = user.save_changes(&*conn).map_err(Error::from)?;
 

templates/instance/emailblocklist.rs.html

@@ -32,9 +32,9 @@
     <form method="post" action="@uri!(instance::delete_email_blocklist)">
         <header>
             @if emails.is_empty() {
-               <p class="center" >@i18n!(ctx.1, "There are no blocked emails on your instance")</p>
-            } else {
                <input type="submit" class="destructive" value='@i18n!(ctx.1, "Delete selected emails")'>
+            } else {
+               <p class="center" >@i18n!(ctx.1, "There are no blocked emails on your instance")</p>
             }
         </header>
     <div class="list">

templates/partials/post_card.rs.html

@@ -17,30 +17,17 @@
         <p class="p-summary" dir="auto">@article.subtitle</p>
     </main>
     <footer class="authors">
-        <div>
+        @Html(i18n!(ctx.1, "By {0}"; format!(
-            @Html(i18n!(ctx.1, "By {0}"; format!(
+            "<a class=\"p-author h-card\" href=\"{}\">{}</a>",
-                "<a class=\"p-author h-card\" href=\"{}\">{}</a>",
+            uri!(user::details: name = &article.get_authors(ctx.0).unwrap_or_default()[0].fqn),
-                uri!(user::details: name = &article.get_authors(ctx.0).unwrap_or_default()[0].fqn),
+            escape(&article.get_authors(ctx.0).unwrap_or_default()[0].name())
-                escape(&article.get_authors(ctx.0).unwrap_or_default()[0].name())
+        )))
-            )))
+        @if article.published {
-            @if article.published {
+	       ⋅ <span class="dt-published" datetime="@article.creation_date.format("%F %T")">@article.creation_date.format("%B %e, %Y")</span>
-                ⋅ <span class="dt-published" datetime="@article.creation_date.format("%F %T")">@article.creation_date.format("%B %e, %Y")</span>
+        }
-            }
+        ⋅ <a href="@uri!(blogs::details: name = &article.get_blog(ctx.0).unwrap().fqn, page = _)">@article.get_blog(ctx.0).unwrap().title</a>
-            ⋅ <a href="@uri!(blogs::details: name = &article.get_blog(ctx.0).unwrap().fqn, page = _)">@article.get_blog(ctx.0).unwrap().title</a>
-            ⋅
-        </div>
         @if !article.published {
-            <div>⋅ @i18n!(ctx.1, "Draft")</div>
+            ⋅ @i18n!(ctx.1, "Draft")
-        } else {
-            <div>
-                <span class="likes" aria-label="@i18n!(ctx.1, "One like", "{0} likes"; article.count_likes(ctx.0).unwrap_or_default())" title="@i18n!(ctx.1, "One like", "{0} likes"; article.count_likes(ctx.0).unwrap_or_default())">
-                    @icon!("heart") @article.count_likes(ctx.0).unwrap_or_default()
-                </span>
-                ⋅
-                <span class="reshares" aria-label="@i18n!(ctx.1, "One like", "{0} boost"; article.count_reshares(ctx.0).unwrap_or_default())" title="@i18n!(ctx.1, "One boost", "{0} boosts"; article.count_reshares(ctx.0).unwrap_or_default())">
-                    @icon!("repeat") @article.count_reshares(ctx.0).unwrap_or_default()
-                </span>
-            </div>
         }
     </footer>
 </div>

templates/remote_interact_base.rs.html

@@ -25,7 +25,6 @@
 	    			.default(login_form.password)
 	    			.error(&login_errs)
 	    			.set_prop("minlength", 1)
-				    .input_type("password")
 	    			.html(ctx.1))
 		        <input type="submit" value="@i18n!(ctx.1, "Log in")" />
 	    	</form>