Avoid panics (#392)

- Use `Result` as much as possible
- Display errors instead of panicking

TODO (maybe in another PR? this one is already quite big):
- Find a way to merge Ructe/ErrorPage types, so that we can have routes returning `Result<X, ErrorPage>` instead of panicking when we have an `Error`
- Display more details about the error, to make it easier to debug

(sorry, this isn't going to be fun to review, the diff is huge, but it is always the same changes)

src/routes/notifications.rs

@@ -3,18 +3,18 @@ use rocket_i18n::I18n;
 
 use plume_common::utils;
 use plume_models::{db_conn::DbConn, notifications::Notification, users::User};
-use routes::Page;
+use routes::{Page, errors::ErrorPage};
 use template_utils::Ructe;
 
 #[get("/notifications?<page>")]
-pub fn notifications(conn: DbConn, user: User, page: Option<Page>, intl: I18n) -> Ructe {
+pub fn notifications(conn: DbConn, user: User, page: Option<Page>, intl: I18n) -> Result<Ructe, ErrorPage> {
     let page = page.unwrap_or_default();
-    render!(notifications::index(
+    Ok(render!(notifications::index(
         &(&*conn, &intl.catalog, Some(user.clone())),
-        Notification::page_for_user(&*conn, &user, page.limits()),
+        Notification::page_for_user(&*conn, &user, page.limits())?,
         page.0,
-        Page::total(Notification::count_for_user(&*conn, &user) as i32)
-    ))
+        Page::total(Notification::count_for_user(&*conn, &user)? as i32)
+    )))
 }
 
 #[get("/notifications?<page>", rank = 2)]