Avoid panics (#392)

- Use `Result` as much as possible
- Display errors instead of panicking

TODO (maybe in another PR? this one is already quite big):
- Find a way to merge Ructe/ErrorPage types, so that we can have routes returning `Result<X, ErrorPage>` instead of panicking when we have an `Error`
- Display more details about the error, to make it easier to debug

(sorry, this isn't going to be fun to review, the diff is huge, but it is always the same changes)

src/routes/likes.rs

@@ -11,27 +11,28 @@ use plume_models::{
     users::User
 };
 use Worker;
+use routes::errors::ErrorPage;
 
 #[post("/~/<blog>/<slug>/like")]
-pub fn create(blog: String, slug: String, user: User, conn: DbConn, worker: Worker) -> Option<Redirect> {
+pub fn create(blog: String, slug: String, user: User, conn: DbConn, worker: Worker) -> Result<Redirect, ErrorPage> {
     let b = Blog::find_by_fqn(&*conn, &blog)?;
     let post = Post::find_by_slug(&*conn, &slug, b.id)?;
 
-    if !user.has_liked(&*conn, &post) {
-        let like = likes::Like::insert(&*conn, likes::NewLike::new(&post ,&user));
-        like.notify(&*conn);
+    if !user.has_liked(&*conn, &post)? {
+        let like = likes::Like::insert(&*conn, likes::NewLike::new(&post ,&user))?;
+        like.notify(&*conn)?;
 
-        let dest = User::one_by_instance(&*conn);
-        let act = like.to_activity(&*conn);
+        let dest = User::one_by_instance(&*conn)?;
+        let act = like.to_activity(&*conn)?;
         worker.execute(move || broadcast(&user, act, dest));
     } else {
-        let like = likes::Like::find_by_user_on_post(&*conn, user.id, post.id).expect("likes::create: like exist but not found error");
-        let delete_act = like.delete(&*conn);
-        let dest = User::one_by_instance(&*conn);
+        let like = likes::Like::find_by_user_on_post(&*conn, user.id, post.id)?;
+        let delete_act = like.delete(&*conn)?;
+        let dest = User::one_by_instance(&*conn)?;
         worker.execute(move || broadcast(&user, delete_act, dest));
     }
 
-    Some(Redirect::to(uri!(super::posts::details: blog = blog, slug = slug, responding_to = _)))
+    Ok(Redirect::to(uri!(super::posts::details: blog = blog, slug = slug, responding_to = _)))
 }
 
 #[post("/~/<blog>/<slug>/like", rank = 2)]