Run cargo clippy on whole project (#322)

* Run cargo clippy on plume-common

Run clippy on plume-common and adjuste code accordingly

* Run cargo clippy on plume-model

Run clippy on plume-model and adjuste code accordingly

* Reduce need for allocation in plume-common

* Reduce need for allocation in plume-model

add a quick compilation failure if no database backend is enabled

* Run cargo clippy on plume-cli

* Run cargo clippy on plume

src/routes/reshares.rs

@@ -13,8 +13,8 @@ use plume_models::{
 
 #[post("/~/<blog>/<slug>/reshare")]
 fn create(blog: String, slug: String, user: User, conn: DbConn, worker: State<Pool<ThunkWorker<()>>>) -> Option<Redirect> {
-    let b = Blog::find_by_fqn(&*conn, blog.clone())?;
-    let post = Post::find_by_slug(&*conn, slug.clone(), b.id)?;
+    let b = Blog::find_by_fqn(&*conn, &blog)?;
+    let post = Post::find_by_slug(&*conn, &slug, b.id)?;
 
     if !user.has_reshared(&*conn, &post) {
         let reshare = Reshare::insert(&*conn, NewReshare {
@@ -26,7 +26,7 @@ fn create(blog: String, slug: String, user: User, conn: DbConn, worker: State<Po
         reshare.notify(&*conn);
 
         let dest = User::one_by_instance(&*conn);
-        let act = reshare.into_activity(&*conn);
+        let act = reshare.to_activity(&*conn);
         worker.execute(Thunk::of(move || broadcast(&user, act, dest)));
     } else {
         let reshare = Reshare::find_by_user_on_post(&*conn, user.id, post.id)
@@ -43,6 +43,6 @@ fn create(blog: String, slug: String, user: User, conn: DbConn, worker: State<Po
 fn create_auth(blog: String, slug: String) -> Flash<Redirect> {
     utils::requires_login(
         "You need to be logged in order to reshare a post",
-        uri!(create: blog = blog, slug = slug).into()
+        uri!(create: blog = blog, slug = slug)
     )
 }