Run cargo clippy on whole project (#322)

* Run cargo clippy on plume-common

Run clippy on plume-common and adjuste code accordingly

* Run cargo clippy on plume-model

Run clippy on plume-model and adjuste code accordingly

* Reduce need for allocation in plume-common

* Reduce need for allocation in plume-model

add a quick compilation failure if no database backend is enabled

* Run cargo clippy on plume-cli

* Run cargo clippy on plume

plume-cli/src/instance.rs

@@ -46,12 +46,12 @@ fn new<'a>(args: &ArgMatches<'a>, conn: &Connection) {
         .unwrap_or_else(|| env::var("BASE_URL")
             .unwrap_or_else(|_| super::ask_for("Domain name")));
     let name = args.value_of("name").map(String::from).unwrap_or_else(|| super::ask_for("Instance name"));
-    let license = args.value_of("default-license").map(String::from).unwrap_or(String::from("CC-BY-SA"));
+    let license = args.value_of("default-license").map(String::from).unwrap_or_else(|| String::from("CC-BY-SA"));
     let open_reg = !args.is_present("private");
 
     Instance::insert(conn, NewInstance {
         public_domain: domain,
-        name: name,
+        name,
         local: true,
         long_description: SafeString::new(""),
         short_description: SafeString::new(""),

plume-cli/src/users.rs

@@ -70,8 +70,8 @@ fn new<'a>(args: &ArgMatches<'a>, conn: &Connection) {
         username,
         display_name,
         admin,
-        bio,
+        &bio,
         email,
-        User::hash_pass(password),
+        User::hash_pass(&password),
     ).update_boxes(conn);
 }