Big refactoring of the Inbox (#443)

* Big refactoring of the Inbox

We now have a type that routes an activity through the registered handlers
until one of them matches.

Each Actor/Activity/Object combination is represented by an implementation of AsObject

These combinations are then registered on the Inbox type, which will try to deserialize
the incoming activity in the requested types.

Advantages:
- nicer syntax: the final API is clearer and more idiomatic
- more generic: only two traits (`AsActor` and `AsObject`) instead of one for each kind of activity
- it is easier to see which activities we handle and which one we don't

* Small fixes

- Avoid panics
- Don't search for AP ID infinitely
- Code style issues

* Fix tests

* Introduce a new trait: FromId

It should be implemented for any AP object.

It allows to look for an object in database using its AP ID, or to dereference it if it was not present in database

Also moves the inbox code to plume-models to test it (and write a basic test for each activity type we handle)

* Use if let instead of match

* Don't require PlumeRocket::intl for tests

* Return early and remove a forgotten dbg!

* Add more tests to try to understand where the issues come from

* Also add a test for comment federation

* Don't check creation_date is the same for blogs

* Make user and blog federation more tolerant to errors/missing fields

* Make clippy happy

* Use the correct Accept header when dereferencing

* Fix follow approval with Mastodon

* Add spaces to characters that should not be in usernames

And validate blog names too

* Smarter dereferencing: only do it once for each actor/object

* Forgot some files

* Cargo fmt

* Delete plume_test

* Delete plume_tests

* Update get_id docs + Remove useless : Sized

* Appease cargo fmt

* Remove dbg! + Use as_ref instead of clone when possible + Use and_then instead of map when possible

* Remove .po~

* send unfollow to local instance

* read cover from update activity

* Make sure "cc" and "to" are never empty

and fix a typo in a constant name

* Cargo fmt
This commit is contained in:
Baptiste Gelez
2019-04-17 18:31:47 +01:00
committed by GitHub
parent c19c094e0c
commit 12efe721cc
49 changed files with 2883 additions and 1521 deletions
+13 -12
View File
@@ -42,6 +42,9 @@ msgstr "{{ name}} のアバター"
msgid "To create a new blog, you need to be logged in"
msgstr ""
msgid "A blog with the same name already exists."
msgstr "同じ名前のブログがすでに存在します。"
#, fuzzy
msgid "You are not allowed to delete this blog."
msgstr "あなたはこのブログの作者ではありません。"
@@ -216,8 +219,8 @@ msgid "Allow anyone to register here"
msgstr "不特定多数に登録を許可"
#, fuzzy
msgid "Short description - byline"
msgstr "短い説明"
msgid "Short description"
msgstr "長い説明"
#, fuzzy
msgid "Markdown syntax is supported"
@@ -237,7 +240,7 @@ msgstr "設定を保存"
msgid "About {0}"
msgstr ""
msgid "Home to <em>{0}</em> users"
msgid "Home to <em>{0}</em> people"
msgstr ""
msgid "Who wrote <em>{0}</em> articles"
@@ -379,7 +382,7 @@ msgid "Subscribe"
msgstr ""
#, fuzzy
msgid "{0}'s subscriptions'"
msgid "{0}'s subscriptions"
msgstr "説明"
#, fuzzy
@@ -403,7 +406,7 @@ msgid "Plume is a decentralized blogging engine."
msgstr "Plume は分散型ブログエンジンです。"
#, fuzzy
msgid "Authors can manage various blogs, each as an unique website."
msgid "Authors can manage multiple blogs, each as its own website."
msgstr "作成者は、ある固有の Web サイトから、さまざまなブログを管理できます。"
#, fuzzy
@@ -414,9 +417,6 @@ msgstr ""
"記事は他の Plume Web サイトからも閲覧可能であり、Mastdon のように他のプラット"
"フォームから直接記事と関わることができます。"
msgid "Home to <em>{0}</em> people"
msgstr ""
msgid "Read the detailed rules"
msgstr "詳細な規則を読む"
@@ -649,7 +649,7 @@ msgstr "いいねする"
#, fuzzy
msgid "One boost"
msgid_plural "{0} boost"
msgid_plural "{0} boosts"
msgstr[0] "{0} ブースト"
#, fuzzy
@@ -837,6 +837,10 @@ msgstr "このメディアを記事に挿入するには、自分の記事にコ
msgid "Use as an avatar"
msgstr "アバターとして使う"
#, fuzzy
#~ msgid "Short description - byline"
#~ msgstr "短い説明"
#~ msgid "Login"
#~ msgstr "ログイン"
@@ -943,9 +947,6 @@ msgstr "アバターとして使う"
#~ msgid "Invalid name"
#~ msgstr "無効な名前"
#~ msgid "A blog with the same name already exists."
#~ msgstr "同じ名前のブログがすでに存在します。"
#~ msgid "Your comment can't be empty"
#~ msgstr "コメントは空にできません"