From be99fe5f9977a3541526742c85b581772f3aff0b Mon Sep 17 00:00:00 2001 From: Kitaiti Makoto Date: Tue, 19 Jan 2021 23:31:31 +0900 Subject: [PATCH] Implement Post::get_blog_fqn() --- plume-models/src/posts.rs | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/plume-models/src/posts.rs b/plume-models/src/posts.rs index fbb03261..98483491 100644 --- a/plume-models/src/posts.rs +++ b/plume-models/src/posts.rs @@ -12,6 +12,7 @@ use activitypub::{ use chrono::{NaiveDateTime, TimeZone, Utc}; use diesel::{self, BelongingToDsl, ExpressionMethods, QueryDsl, RunQueryDsl, SaveChangesDsl}; use heck::KebabCase; +use once_cell::sync::Lazy; use plume_common::{ activity_pub::{ inbox::{AsObject, FromId}, @@ -20,11 +21,13 @@ use plume_common::{ utils::md_to_html, }; use riker::actors::{Publish, Tell}; -use std::collections::HashSet; -use std::sync::Arc; +use std::collections::{HashMap, HashSet}; +use std::sync::{Arc, Mutex}; pub type LicensedArticle = CustomObject; +static BLOG_FQN_CACHE: Lazy>> = Lazy::new(|| Mutex::new(HashMap::new())); + #[derive(Queryable, Identifiable, Clone, AsChangeset, Debug)] #[changeset_options(treat_none_as_null = "true")] pub struct Post { @@ -275,6 +278,24 @@ impl Post { .map_err(Error::from) } + /// This method exists for use in templates to reduce database access. + /// This should not be used for other purpose. + /// + /// This caches query result. The best way to cache query result is holding it in `Post`s field + /// but Diesel doesn't allow it currently. + /// If sometime Diesel allow it, this method should be removed. + pub fn get_blog_fqn(&self, conn: &Connection) -> String { + if let Some(blog_fqn) = BLOG_FQN_CACHE.lock().unwrap().get(&self.blog_id) { + return blog_fqn.to_string(); + } + let blog_fqn = self.get_blog(conn).unwrap().fqn; + BLOG_FQN_CACHE + .lock() + .unwrap() + .insert(self.blog_id, blog_fqn.clone()); + blog_fqn + } + pub fn count_likes(&self, conn: &Connection) -> Result { use crate::schema::likes; likes::table